View Issue Details

IDCategoryLast Update
0008558bugs2021-02-02 21:42
ReportersjaehnAssigned Tox42 
Reproducibilityhave not tried 
Status resolvedResolutionfixed 
Product Version6.5 
Fixed in Version 
Summary0008558: LV2_Atom_Bool
DescriptionI got an information from Reaper about a bug in my B.Music plugins and following a `grep` scan of all my git clones I saw the same in the code of Ardour:
https://github.com/Ardour/ardour/blob/master/libs/ardour/lv2_plugin.cc#L580 contains
```
        { LV2_OPTIONS_INSTANCE, 0, _uri_map.uri_to_id("http://ardour.org/lv2/theme/#styleBoxy"),
          sizeof(bool), atom_Bool, &_ui_style_boxy },
        { LV2_OPTIONS_INSTANCE, 0, _uri_map.uri_to_id("http://ardour.org/lv2/theme/#styleFlat"),
          sizeof(bool), atom_Bool, &_ui_style_flat },
```

`LV2_Atom_Bool` is defined as an `LV2_Atom_Int` in the specs and thus contains a four byte value. However, `sizeof(bool)` returns 1 for the most systems.

I don't know if this is evident in the case of Ardour. This report is only the result of a code scan. I didn't experimentally tested it.
TagsNo tags attached.

Activities

x42

2021-02-02 21:42

administrator   ~0025484

Thanks for the heads up. Fixed in 6.5-199-gb50a6fbe17

Issue History

Date Modified Username Field Change
2021-02-01 15:28 sjaehn New Issue
2021-02-02 21:42 x42 Note Added: 0025484
2021-02-02 21:42 x42 Assigned To => x42
2021-02-02 21:42 x42 Status new => resolved
2021-02-02 21:42 x42 Resolution open => fixed